Code Review Checklist

Technical Reference & Key Concepts

**What to look for in every review:** - **Correctness:** Does the code handle edge cases? Empty arrays, null inputs, concurrent access? - **Security:** Are user inputs sanitized? SQL injection, XSS, CSRF, SSRF risks? - **Performance:** N+1 queries in loops? Unnecessary object allocations? Could this be cached? - **Maintainability:** Is the code readable? Would another engineer understand it in 6 months? - **Testing:** Are there unit tests for the critical paths? Error cases tested? - **Error Handling:** Are errors caught and logged appropriately? Graceful degradation? - **Logging & Observability:** Are key decisions and failures logged? Can we debug this in production? **Tone Tips:** Ask questions ("What happens if X is null?") instead of making demands ("Add null check"). Frame feedback as learning opportunities.

Practice discussing these concepts out loud in live voice drills on GitGrilled.